PrestaShop Core Weekly - Week 07 of 2019
An inside look at the PrestaShop codebase
This edition of the Core Weekly report highlights changes in PrestaShop’s core codebase from Monday 11th to Sunday 17th of February 2019.
General messages
Dear Developers,
During week seven, the team had some issues with Travis, and, the time to fix that, it was a bit difficult to merge pull requests. However, 45 pull requests were merged. Good job guys!
A quick update about PrestaShop’s GitHub issues and pull requests:
- 53 new issues have been created in the project repositories
- 38 issues have been closed, including 6 fixed issues on the core.
- 64 pull requests have been opened in the project repositories
- 60 pull requests have been closed, including 45 merged pull requests
Code changes in the ‘develop’ branch (for v1.7.6.0)
Core
- #11764: CO : Undefined variable. Thank you @idnovate
- #12124: Remove unwanted umask, by @PierreRambaud
- #12152: Fixed (by temporary hacking) #12151 ‘Timezone standard is ignored’. Thank you @michaesc
- #12473: Order Creation: fix out of stock status, by @rGaillard
- #12484: Fix missing tag for CustomerType. Thank you @sarjon
- #12532: Updated Core using new version of Composer script handler, by @mickaelandrieu
- #12543: Update vulnerable dependencies, by @eternoendless
Back office
- #10877: Migration of “Design > Pages” page cms category listing. Thank you @tomas862
- #12471: Use AdminSecurity annotation for ajax call for Sql Manager, by @matks
Front office
- #12403: Attribute min not allowed on element input at this point, change type…. Thank you @dominictayloruk
Tests
- #12574: Fix PositionsControllerTest for good, by @jolelievre
Code changes in the ‘1.7.5.x’ branch (for v1.7.5.1)
Back Office
- #12507: Add hookDispatcher in GridFactory constructor, HookDispatcherAwareTrait has a safer getter, by @jolelievre
Code changes in modules, themes & tools
Mail alerts
- #17: Correct product name and link if it has attributes. Thank you @kpodemski
Traces
- #2: Make timeout configurable, by @mickaelandrieu
Composer script handler
- #4: Asks confirmation before overwrite the existing modules, by @mickaelandrieu
- #5: Made overwritting behavior “overwrite” the output for real, by @jolelievre
- #6: Allow to deactivate overwriting using env variable, by @mickaelandrieu
PrestaShop Cleaner
- #21: Add cart_rule_lang in Check And Fix to delete old cart rule’s names.. Thank you @Uebix
- #27: Blank lines. Thank you @MathiasReker
- #30: Cast spaces. Thank you @MathiasReker
- #32: Single quote. Thank you @MathiasReker
- #33: Lossless compression. Thank you @MathiasReker
Gamification
- #38: Fix php docs and comments. Thank you @MathiasReker
- #43: Include. Thank you @MathiasReker
- #44: Php unit test case static method calls. Thank you @MathiasReker
- #45: Single quote. Thank you @MathiasReker
- #46: Random api migration. Thank you @MathiasReker
- #47: Space after semicolon. Thank you @MathiasReker
- #49: Unary operator spaces. Thank you @MathiasReker
- #50: Is null. Thank you @MathiasReker
- #51: Function to constant. Thank you @MathiasReker
- #52: Dir constant. Thank you @MathiasReker
- #53: Normalize line ending lf unix. Thank you @MathiasReker
- #54: Php unit set up tear down visibility. Thank you @MathiasReker
- #56: Blank lines. Thank you @MathiasReker
- #57: Beautify yml files. Thank you @MathiasReker
Buy Button Lite
- #15: Class attributes separation. Thank you @MathiasReker
- #16: Trailing comma in multiline array. Thank you @MathiasReker
- #18: Is null. Thank you @MathiasReker
- #20: Cast spaces. Thank you @MathiasReker
- #22: Lossless compression. Thank you @MathiasReker
- #24: Happy new year 2019. Thank you @MathiasReker
- #26: fix wording. Thank you @MathiasReker
Changes in Documentation
- #204: Added a note on service declaration in Yaml, by @mickaelandrieu
Thank you to the contributors whose pull requests were merged since the last Core Weekly Report: @dominictayloruk, @idnovate, @kpodemski, @MathiasReker, @michaesc, @tomas862, @Uebix !
Thank you to the contributors whose PRs haven’t been merged yet! And of course, a big thank you to all those who contribute with issues and comments on GitHub!
If you want to contribute to PrestaShop with code, please read these pages first:
…and if you do not know how to fix an issue but wish to report it, please read this: How to use GitHub to report an issue. Thank you!
Happy contributin’ everyone!