PrestaShop Core Weekly - Week 50 of 2018
An inside look at the PrestaShop codebase
This edition of the Core Weekly report highlights changes in PrestaShop’s core codebase during the last week, from Monday 10th to Sunday 16th of December 2018.
General messages
Dear Developers,
Did you notice the new banner on the Core Weekly? It now matches the new theme of prestashop.com ;-)
Also, last week, a few 2018 records have been broken on PrestaShop project’s repositories on GitHub:
- 78 pull request merged in one week, including
- 40 pull requests merged only for the Core, and
- 41 pull requests merged from a single contributor, @MathiasReker who is passionate about code lint
- 80% of the PR were from contributors external to the PrestaShop company
It means two things:
- You are an amazing team of contributors, contributing more and more with quality pull requests, easier to review and to merge
- It helps to improve the maintainers productivity on code review and merge
How the end of the year could be better for an open source projet? Congratulations to all PrestaShop developers for this amazing year.
A quick update about GitHub issues
Last week, 37 new issues have been created in PrestaShop’s core repository, and 8 fixed issues have been closed.
Code changes in the ‘develop’ branch (for v1.7.6.0)
Core
- #10533: CO: add old product ID on actionProductAdd hook when we duplicate product. Thank you @duGuillaume
- #10975: Introduced a new function for Products.php for retrive a product ID given it reference. Thank you @runningz
- #11635: improve use of protocol. Thank you @MathiasReker
- #11643: Additional PHP Improvements. Thank you @MathiasReker
- #11645: Fix discount computing to take combination into account, by @jolelievre
- #11653: Allowed the override of PS_DEBUG_PROFILING. Thank you @SebBareyre
- #11666: Fully qualified strict types. Thank you @MathiasReker
- #11667: Heredoc to nowdoc. Thank you @MathiasReker
- #11669: Improve error suppression. Thank you @MathiasReker
- #11671: Use constant instead of function. Thank you @MathiasReker
- #11672: Non printable character. Thank you @MathiasReker
- #11678: Fix use of protocol. Thank you @MathiasReker
- #11679: Fix issue with deleting a category with subcategories on Multistore. Thank you @MathiasReker
- #11685: php-cs-fixer: Fix “non printable character”. Thank you @MathiasReker
- #11689: Merge 1.7.5.x in develop, by @PierreRambaud
- #11691: Fix bug on pdf logo path. Thank you @SebBareyre
- #11694: Align multiline comment. Thank you @MathiasReker
- #11695: Array indentation. Thank you @MathiasReker
- #11696: Combine consecutive issets. Thank you @MathiasReker
- #11697: Combine consecutive unsets. Thank you @MathiasReker
- #11699: Hash to slash comment. Thank you @MathiasReker
- #11701: Use logical operators. Thank you @MathiasReker
- #11703: Do not use short echo tags. Thank you @MathiasReker
- #11704: Remove useless return. Thank you @MathiasReker
- #11707: Do not use alias functions. Thank you @MathiasReker
- #11708: Modernize types casting. Thank you @MathiasReker
- #11709: Use echo instead of print. Thank you @MathiasReker
- #11710: Include is not a function. Thank you @MathiasReker
- #11711: Add missing braces. Thank you @MathiasReker
- #11712: Normalize use of operators. Thank you @MathiasReker
- #11714: Fix lineending. Thank you @MathiasReker
- #11731: Fix typo. Thank you @MathiasReker
- #11733: Add function type. Thank you @MathiasReker
- #11734: Remove comma in single array. Thank you @MathiasReker
- #11735: Elseif instead of else if. Thank you @MathiasReker
- #11736: Remove unused imports. Thank you @MathiasReker
- #11738: No PHP closing tag and no EOL. Thank you @MathiasReker
- #11744: Fix PhpDoc Validate::isColor(). Thank you @EdouardTack
- #11747: Convert comments to php docs in some cases. Thank you @MathiasReker
- #11757: Remove empty statement. Thank you @MathiasReker
Back office
- #11200: Addresses changes not impacted when creating an order from another order. Thank you @jf-viguier
- #11201: Addresses changes not impacted when creating an order from another order. Thank you @jf-viguier
- #11519: Migrate Customers KPIs and required fields configuration. Thank you @sarjon
- #11527: Migrate customer view actions. Thank you @sarjon
- #11732: Avoid using short bool. Thank you @MathiasReker
- #11739: Remove blackslash. Thank you @MathiasReker
- #11741: Use brackets for index brace. Thank you @MathiasReker
Front office
- #11614: Custom product flags using module. Thank you @kpodemski
- #11656: Correctly display percentage in cart, by @jolelievre
Tests
- #11674: Simplify PHP unit construct. Thank you @MathiasReker
- #11675: Simplify PHP unit expectations. Thank you @MathiasReker
- #11676: Use camelcase instead of snakecase in functions. Thank you @MathiasReker
- #11677: Fix wrong name. Thank you @MathiasReker
- #11762: Add branch in nightly releases, by @Quetzacoalt91
- #11766: Create, edit, delete, exchange rate currency. Thank you @ansar21mallouli
- #11768: Import localization pack. Thank you @ansar21mallouli
Code changes in the ‘1.7.5.x’ branch (for v1.7.5.0
Front office
Tests
- #11659: Update dependencies version. Thank you @hadrich-hatem
- #11690: Fix install_upgrade campaign. Thank you @ansar21mallouli
Code changes in modules, themes & tools
Google Sitemap
- #71: Minor improvements. Thank you @MathiasReker
Products in the same category
- #6: Wrong cache key used in ps_categoryproducts. Thank you @Matt75
- #8: Deploying v1.0.4 of ps_categoryproducts, by @Quetzacoalt91
Link list
- #57: Fix update when table cms_block_page does not exist, by @jolelievre
- #59: Deploy v3.0.2 of ps_linklist, by @Quetzacoalt91
MBO
- #76: Character issue, by @MrBaiame
- #77: Merge fixes to master, by @jolelievre
- #78: Update version to 1.1.1, by @jolelievre
- #79: Update version to 1.1.1, by @jolelievre
Catalog evalutation
Visits and Visitors
Visitors online
GDPR
PrestaFraud
- #11: Replace Forge URL by GitHub issues, by @eternoendless
Docker internal images
- #19: Expose HTTPS port, by @Quetzacoalt91
Changes in Documentation
- #135: Update to Grid docs. Thank you @sarjon
- #168: Add a paragraph in 1.7.5 changes page about the _legacy_link, by @jolelievre
- #172: fixed changedCheckoutStep event name. Thank you @adviva
- #173: Update objectmodel.md. Thank you @arischmod
Thank you to the contributors whose pull requests were merged since the last Core Weekly Report: @adviva, @ansar21mallouli, @arischmod, @duGuillaume, @hadrich-hatem, @jf-viguier, @Kioob, @kpodemski, @Matt75, @runningz, @sarjon, @SebBareyre! And a very special thank to @MathiasReker for this one!
Thank you to the contributors whose PRs haven’t been merged yet! And of course, a big thank you to all those who contribute with issues and comments on GitHub!
If you want to contribute to PrestaShop with code, please read these pages first:
…and if you do not know how to fix an issue but wish to report it, please read this: How to use GitHub to report an issue. Thank you!
Happy contributin’ everyone!