PrestaShop Core Weekly - Week 37 of 2020
An inside look at the PrestaShop codebase
This edition of the Core Weekly report highlights changes in PrestaShop’s core codebase from Monday 7th to Sunday 13th of September 2020.
Releases
A quick update about PrestaShop’s GitHub issues and pull requests:
- 59 new issues have been created in the project repositories;
- 51 issues have been closed, including 9 fixed issues on the core;
- 78 pull requests have been opened in the project repositories;
- 82 pull requests have been closed, including 74 merged pull requests.
Code changes in the ‘develop’ branch
Core
- #20905: The correct instance type of the created Order. Thank you @Seleda
- #20888: Tax and tax name are not recorded. Thank you @dariusakafest
- #20866: Remove $response variable re-declaration. Thank you @davidglezz
- #20601: Allow admin user to configure the SameSite cookie attribute, by @PierreRambaud
Back office
- #20799: Modify discounts listing in Customer page to use Grid - Delete modal, by @sowbiba
- #20591: Introduce Javascript component loading through window.prestashop (part1). Thank you @JevgenijVisockij
- #20508: Fix FormSubmitButton method. Thank you @davidglezz
- #20320: Fixed alert system failing when the $error variable is malformed. Thank you @jimmydupre
- #20200: Use ChoiceType in Log severity column filter. Thank you @PululuK
Front office
- #20909: Cleaner way to have highlighted text on invalid address. Thank you @kpodemski
- #20811: Bump elliptic from 6.4.1 to 6.5.3 in /themes. Thank you @dependabot[bot]
- #20616: Set secure_key in invoice links for guests. Thank you @JoshTheDerf
Installer
- #19850: Remove Escape percentage in parameters, by @Progi1984
Tests
- #20938: Use make assets before installing prestashop in travis ci, by @PierreRambaud
- #20810: Bump lodash from 4.17.15 to 4.17.20 in /tests/UI. Thank you @dependabot[bot]
Merge
- #20939: Merge 177x into develop 08/09/2020, by @jolelievre
Code changes in the ‘1.7.7.x’ branch
Back office
- #20906: Duplicate product in order invoices, by @jolelievre
Front office
- #20920: Fix jquery migrate being loaded two times in FO, by @matthieu-rolland
Tests
- #20922: Add test ‘CRUD states’, by @boubkerbribri
- #20919: Add test ‘Bulk actions zones’, by @boubkerbribri
- #20913: Avoid creating the same name for different values using faker, by @boubkerbribri
- #20899: Add test ‘CRUD Zone’, by @boubkerbribri
- #20896: Add test ‘Filter and quick edit states’, by @boubkerbribri
- #20883: Fix duplicates steps identifiers in UI tests, by @boubkerbribri
- #20881: Add test ‘Filter and quick edit countries’, by @boubkerbribri
- #20876: Add test ‘Filter and quick edit zone’, by @boubkerbribri
- #20873: Improve pagination on customers test, by @boubkerbribri
- #20859: Add test ‘CRUD tax Rule’. Thank you @nesrineabdmouleh
- #20831: Add test ‘CRUD country’. Thank you @nesrineabdmouleh
Code changes in modules, themes & tools
Changes in developer documentation
- #725: writing mistake. Thank you @moncef-essid
- #724: variable name correction. Thank you @moncef-essid
- #721: writing mistake. Thank you @moncef-essid
- #720: writing mistake. Thank you @moncef-essid
- #719: writing mistake. Thank you @moncef-essid
- #718: Fix class name ChoiceCategoriesTreeType. Thank you @LukaS0lncev
- #717: Fix Twitter meta image URL path, by @matks
- #714: describe the correct template type. Thank you @moncef-essid
- #713: Wrong title for image in money with suffix. Thank you @moncef-essid
- #712: Method called twice in filter type reference page. Thank you @moncef-essid
- #711: Correct the SubmitBulkAction name. Thank you @moncef-essid
- #710: Replace AbstractBulkAction by AbstractGridAction. Thank you @moncef-essid
- #709: Correction of subscribe newsletter row action. Thank you @moncef-essid
- #708: Method called twice in work with search form page. Thank you @moncef-essid
- #707: Reorganize Architecture summary, by @matks
Example modules
Dashboard Trends module
- #33: Improve project, by @Progi1984
PrestonBot
- #104: Do not add Waiting for wording when already validated & fix PR validation comment being wrongly removed, by @atomiix
- #103: Use prestashop/github-webhook-parser, by @atomiix
- #102: Link wording to the right diff file and line, by @atomiix
PrestaShop contributors website
- #21: Bump http-proxy from 1.17.0 to 1.18.1. Thank you @dependabot[bot]
- #20: Bump node-sass from 4.9.2 to 4.13.1. Thank you @dependabot[bot]
- #19: Bump bootstrap from 4.1.3 to 4.3.1. Thank you @dependabot[bot]
The PrestaShop open source project
Faceted search module
- #210: Bump css-loader from 4.2.2 to 4.3.0. Thank you @dependabot[bot]
- #209: Bump mini-css-extract-plugin from 0.11.0 to 0.11.1. Thank you @dependabot[bot]
- #208: Bump sass-loader from 7.3.1 to 10.0.2. Thank you @dependabot[bot]
- #207: Bump mini-css-extract-plugin from 0.9.0 to 0.11.0. Thank you @dependabot[bot]
- #206: Allow customization of parts of the search without total rewrite. Thank you @jbenezech
- #205: Release 3.6.0, by @PierreRambaud
Example module mailtheme
- #11: Bump http-proxy from 1.17.0 to 1.18.1. Thank you @dependabot[bot]
- #10: Bump node-sass from 4.12.0 to 4.13.1. Thank you @dependabot[bot]
Order Notifications on the Favicon module
- #21: Bump prestashop/php-dev-tools from 3.8 to 3.9. Thank you @dependabot[bot]
Core Weekly Generator tool
- #47: Bump http-proxy from 1.18.0 to 1.18.1. Thank you @dependabot[bot]
- #46: Bump @hapi/hoek from 8.3.2 to 8.5.1. Thank you @dependabot[bot]
- #45: Bump node-sass from 4.12.0 to 4.13.1. Thank you @dependabot[bot]
Issues Bot
- #8: Bump yargs-parser from 13.1.1 to 13.1.2. Thank you @dependabot[bot]
PHP Developer Tools
- #35: Add a stub for module class, allowing developers to not redefine properies in all modules, by @Quetzacoalt91
Check payment module
- #37: Added Github Actions, composer.lock & Renamed README.md, by @Progi1984
Buy button lite module
- #38: Bump lodash.defaultsdeep from 4.6.0 to 4.6.1 in /app. Thank you @dependabot[bot]
Prestashop UI Kit
- #105: Bump node-sass from 4.13.0 to 4.13.1. Thank you @dependabot[bot]
Docker images
- #226: Add missing versions, use proper php version and add erase / install database parameters, by @PierreRambaud
Customer reassurance block module
- #57: SVG Upload fix. Thank you @antoninblasco
Shopping cart module
- #66: Added workflows for PHPStan, PHPCS, Build Release, by @Progi1984
Custom text module
- #35: Renders form twice on error. Thank you @bhavikvaghani
Thank you to the contributors whose pull requests were merged since the last Core Weekly Report: @moncef-essid, @matks, @LukaS0lncev, @jolelievre, @PierreRambaud, @Progi1984, @atomiix, @dependabot[bot], @boubkerbribri, @matthieu-rolland, @SimonGrn, @kpodemski, @Seleda, @dariusakafest, @davidglezz, @jbenezech, @Quetzacoalt91, @nesrineabdmouleh, @sowbiba, @antoninblasco, @JoshTheDerf, @JevgenijVisockij, @jimmydupre, @PululuK, @bhavikvaghani!
Thank you to the contributors whose PRs haven’t been merged yet! And of course, a big thank you to all those who contribute with issues and comments on GitHub!
If you want to contribute to PrestaShop with code, please read these pages first:
…and if you do not know how to fix an issue but wish to report it, please read this: How to use GitHub to report an issue. Thank you!
Happy contributin’ everyone!